Re: [PATCH] D21946: Subject: [PATCH] [Driver] fix windows SDK detect

2016-07-27 Thread comicfans44 via cfe-commits
comicfans44 added a comment. In https://reviews.llvm.org/D21946#473071, @zturner wrote: > In https://reviews.llvm.org/D21946#473070, @comicfans44 wrote: > > > I've not commited to cfe before, so I think I havn't commit access > > permission. > > > If you've committed anywhere in LLVM, you

Re: [PATCH] D21946: Subject: [PATCH] [Driver] fix windows SDK detect

2016-07-01 Thread comicfans44 via cfe-commits
comicfans44 added a comment. neither did I commited to LLVM ... so I'll wait. http://reviews.llvm.org/D21946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21946: Subject: [PATCH] [Driver] fix windows SDK detect

2016-07-01 Thread comicfans44 via cfe-commits
comicfans44 created this revision. comicfans44 added reviewers: zturner, majnemer. comicfans44 added a subscriber: cfe-commits. 1. readFullStringValue returns bool, should not compared with ERROR_SUCCESS 2. RegQueryValueExW string may contain null terminating char ,should be trimmed these leads