[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

2023-05-30 Thread hassnaaHamdi via Phabricator via cfe-commits
hassnaa-arm added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:42 // q -> Scalable vector, followed by the number of elements and the base type. +// Q -> AArch64 svcount_t builtin type. // E -> ext_vector, followed by the number of elements and the bas

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

2023-05-30 Thread hassnaaHamdi via Phabricator via cfe-commits
hassnaa-arm added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:42 // q -> Scalable vector, followed by the number of elements and the base type. +// Q -> AArch64 svcount_t builtin type. // E -> ext_vector, followed by the number of elements and the bas

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

2023-05-31 Thread hassnaaHamdi via Phabricator via cfe-commits
hassnaa-arm added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:56 // P: boolean +// Qa: svcount // U: unsigned sdesmalen wrote: > The typespec modifier in this file can remain `Q` rather than `Qa`. Can you > change it back? what if there i

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

2023-06-08 Thread hassnaaHamdi via Phabricator via cfe-commits
hassnaa-arm added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:2123 + +def SVPSEL_COUNT_ALIAS_B : SInst<"svpsel_lane_c8", "}}Pmi", "Pc", MergeNone, "", [], [ImmCheck<3, ImmCheck0_15>]>; +def SVPSEL_COUNT_ALIAS_H : SInst<"svpsel_lane_c16", "}}Pmi", "Ps", Mer

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

2023-06-09 Thread hassnaaHamdi via Phabricator via cfe-commits
hassnaa-arm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9633-9635 +bool IsSVCount = isa(Ops[0]->getType()); +assert(((!IsSVCount || cast(Ops[0]->getType())->getName() == + "aarch64.svcount")) && hassnaa