[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. I'm not sure how to test this, is there any check dependency we can rely on with hardcoded tests ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. Your understanding is correct, I'm currently just trying to hide them at the end (warnings-as-errors or not). This is how it worked until 5d12b13b0b26bc58b02ee23c369da8b83240cceb (present in LLVM 16) w

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz created this revision. kiwixz added a reviewer: njames93. kiwixz added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. kiwixz requested review of this revision. Herald added a subscriber: cfe-commits. Since commit 5d12

[PATCH] D88668: [CUDA] Add support for 11.1

kiwixz abandoned this revision. kiwixz added a comment. Fixed in a much proper way in D89832 . Thanks @tra! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88668/new/ https://reviews.llvm.org/D88668 ___

[PATCH] D88668: [CUDA] Add support for 11.1

kiwixz added a comment. In D88668#2306393 , @jlebar wrote: >> It looks like 11.1 doesn't have a version.txt file > > Yikes, this is a problem if we can't tell the difference between CUDA > versions! It looks like a blunder from NVIDIA, CUDA 11.1 actually

[PATCH] D88668: [CUDA] Add support for 11.1

kiwixz created this revision. kiwixz added reviewers: jlebar, tra. kiwixz added a project: clang. Herald added subscribers: cfe-commits, yaxunl, jholewinski. kiwixz requested review of this revision. It looks like 11.1 doesn't have a version.txt file, so I changed the default guess in this case f