[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

2023-02-13 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien added a comment. @yaxunl Could you please commit this change on my behalf? I don't have a write access to the trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143495/new/ https://reviews.llvm.org/D143495 __

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

2023-02-07 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien created this revision. pvellien added reviewers: yaxunl, b-sumner. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. pvellien requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: cl

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

2022-01-18 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien added a comment. In D116216#3251066 , @yaxunl wrote: > LGTM. Thanks. Could you please commit on my behalf? I don't have a commit access to llvm trunk CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

2022-01-18 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien updated this revision to Diff 400750. pvellien added a comment. Removed amdgpu-asan-noprintf.cu and added amdgpu-asan-printf.cu testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 Files: clang/lib/CodeGen/CodeGenModule.cpp c

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

2022-01-09 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien updated this revision to Diff 398519. pvellien added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. @lebedev.ri updated with test-cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 Files: clang/lib/CodeGen/Code

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

2021-12-24 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien added a comment. @yaxunl It would be very much helpful to know how to write test coverage for this particular patch? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 __

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

2021-12-23 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien added a comment. The testcases related to this patch are already added via this patch https://reviews.llvm.org/D112820. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 __

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

2021-12-23 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien created this revision. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, kzhuravl. pvellien requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. HIP program with printf call fails to compile with -fsanitize=address option,

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

2020-12-24 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien abandoned this revision. pvellien added a comment. This change is wrong, the different patch is landed in llvm to handle global address space access in gfx60x for HSA Os. So closing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92115/new/ https://reviews.llvm.org/D92115 _

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

2020-11-27 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:134 + if (isAmdHsaOS() && getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) { +report_fatal_error("GFX6 (SI) ASICs does not support AMD HSA OS type \n", + false);

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

2020-11-27 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:2109-2112 +Caution: + AMD HSA Os is not supported in Southern Islands (GFX6) ASICs. + For example: t-tye wrote: > This is not the right place for mentioning this. The Processor table would >

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

2020-11-27 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien updated this revision to Diff 308015. pvellien added a comment. Updated with stanislav comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92115/new/ https://reviews.llvm.org/D92115 Files: clang/test/CodeGenOpenCL/amdgpu-attrs.cl llvm/docs/AMDGPUUsage.rst llvm/lib/Ta

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

2020-11-25 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien created this revision. pvellien added reviewers: rampitec, arsenm, sameerds. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. Herald added projects: clang, LLVM. pvellien requested review of this revi