[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-05 Thread Zixuan Wu via Phabricator via cfe-commits
wuzish added a comment. > That (controlling within the headers) sounds good to me. When that lands, > then my understanding is that the `PPCLinuxToolChain` code would be adjusted > to include `ppc_wrappers` in the search path in the general case. Please let > me know if that's not the case. Tha

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-05 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. > I think the name `ppc_wrappers` is accurate to describe its meaning that > wrapping the headers under standard library path or standard header search > path. Thanks for clarifying this for me. In the case where all of the headers are expected to be pre

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-04 Thread Zixuan Wu via Phabricator via cfe-commits
wuzish added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 @hubert.reinterpretcast Thanks for your advice. I think the name `ppc_wrappers` is accurate to describe its meaning that wrapping the headers under standard library path or standard header search path. (Headers in li

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 I'm not particularly concerned about the scoping of the work; however, the `ppc_wrappers` directory is not at all indicative of that scoping. It neither indicates the scope in terms of purpose (provid

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-04 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 yes, it is currently Linux only. I think we can extend it to include other OS like AIX later if needed. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list cfe-

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-03 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a subscriber: cfe-commits. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits