Re: [PATCH][Solaris] Add -lc also when linking shared libraries

2015-09-14 Thread Rafael Espíndola via cfe-commits
r247603 On 7 September 2015 at 13:22, Xan López via cfe-commits wrote: > On Mon, Sep 07, 2015 at 09:07:41AM -0700, Saleem Abdulrasool wrote: >> > Basically check that -lc is present when clang is called in a certain >> > way I guess? Or something more sophisticated? >> >> >> Yeah, that it is pres

Re: [PATCH][Solaris] Add -lc also when linking shared libraries

2015-09-07 Thread Xan López via cfe-commits
e something like this. Patch attached. (If it seems fine please commit it for me, I do not have commit rights) Xan >From b73b50ebd8d14aebc71b5480ad0f33ccf15c5885 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Xan=20L=C3=B3pez?= Date: Mon, 17 Aug 2015 16:04:26 +0200 Subject: [PATCH] [Solaris] Add -lc

Re: [PATCH][Solaris] Add -lc also when linking shared libraries

2015-09-07 Thread Saleem Abdulrasool via cfe-commits
On Mon, Sep 7, 2015 at 7:18 AM, Xan López wrote: > On Sat, Sep 05, 2015 at 12:28:43PM -0700, Saleem Abdulrasool wrote: > > > Ping? > > > > > > > Testcase? Looks fine otherwise. > > Basically check that -lc is present when clang is called in a certain > way I guess? Or something more sophisticate

Re: [PATCH][Solaris] Add -lc also when linking shared libraries

2015-09-07 Thread Xan López via cfe-commits
On Sat, Sep 05, 2015 at 12:28:43PM -0700, Saleem Abdulrasool wrote: > > Ping? > > > > Testcase? Looks fine otherwise. Basically check that -lc is present when clang is called in a certain way I guess? Or something more sophisticated? Xan > > > > > From 8e81d6b095542c0ff1e28cf1f09d675f8afe1a2

Re: [PATCH][Solaris] Add -lc also when linking shared libraries

2015-09-05 Thread Saleem Abdulrasool via cfe-commits
On Fri, Sep 4, 2015 at 1:12 AM, Xan López via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 28, 2015 at 07:53:40PM +0200, Xan López via cfe-commits wrote: > > This is actually needed, otherwise libc won't be added at all. For > > instance when building libclang.so all the libc sym

Re: [PATCH][Solaris] Add -lc also when linking shared libraries

2015-09-04 Thread Xan López via cfe-commits
On Fri, Aug 28, 2015 at 07:53:40PM +0200, Xan López via cfe-commits wrote: > This is actually needed, otherwise libc won't be added at all. For > instance when building libclang.so all the libc symbols won't be > found, with ld warning about libc being an "implicit dependency". > > ((This patch si

[PATCH][Solaris] Add -lc also when linking shared libraries

2015-08-28 Thread Xan López via cfe-commits
This is actually needed, otherwise libc won't be added at all. For instance when building libclang.so all the libc symbols won't be found, with ld warning about libc being an "implicit dependency". ((This patch sits on top of a couple of unreviewed patches that make clang actually work on Solaris