[PATCH] [Commented On] D25019: [clang-tidy] Make add_new_check.py Python 3 compatible

2016-09-30 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. UPD: This patch is eventually causing some problems in Python 3. Working on that. https://reviews.llvm.org/D25019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] [Commented On] D25019: [clang-tidy] Make add_new_check.py Python 3 compatible

2016-09-30 Thread Kirill Bobyrev via cfe-commits
omtcyfz added inline comments. > bkramer wrote in add_new_check.py:16 > Can we rely on six being available? It's not part of the default python > installation afaik. Yes, I am pretty sure about that. Absolute majority of Python projects relies on having six available and Python installation wi

[PATCH] [Commented On] D25019: [clang-tidy] Make add_new_check.py Python 3 compatible

2016-09-30 Thread Benjamin Kramer via cfe-commits
bkramer added inline comments. > add_new_check.py:16 > > +from six.moves import filter > + Can we rely on six being available? It's not part of the default python installation afaik. https://reviews.llvm.org/D25019 ___ cfe-commits mailing list c