[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2881382 , @MaskRay wrote: > Since @glaubitz is here: > > I want to set `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` to on by default so that > the libraries for x86-64 will be in >

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

MaskRay added a comment. Since @glaubitz is here: I want to set `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` to on by default so that the libraries for x86-64 will be in `lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a` instead of

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66ab8568c485: [Driver] Fix compiler-rt lookup for x32 (authored by hvdijk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2880499 , @hvdijk wrote: > Updated to use `Triple.isX32()`. > > Should we perhaps just merge this as is, ahead of the update to compiler-rt > to create x32 objects? For non-x32, this change is NFC, for x32, the

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk updated this revision to Diff 359016. hvdijk edited the summary of this revision. hvdijk added a reviewer: MaskRay. hvdijk added a comment. Updated to use `Triple.isX32()`. Should we perhaps just merge this as is, ahead of the update to compiler-rt to create x32 objects? For non-x32,

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. @hvdijk I just noticed that the sanitizer defines `SANITIZER_X32` for x32, so I assume your patch itself is already correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added a comment. In D100148#2683748 , @glaubitz wrote: > Understood. However, I'm not really sure what else we need. Do we just take > the architecture definition from here to pass the proper flags to the > compiler or do we also need to add >

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2683710 , @hvdijk wrote: > In D100148#2683325 , @glaubitz > wrote: > >> Hi! Can we get this patch merged as-is or do we need anything else? > > Sorry, miscommunication. I was

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added a comment. In D100148#2683325 , @glaubitz wrote: > Hi! Can we get this patch merged as-is or do we need anything else? Sorry, miscommunication. I was thinking you could use this to update D99988 to

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. Hi! Can we get this patch merged as-is or do we need anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148 ___ cfe-commits

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. So, we only need D99988 and this one (D100148 ) now and the LLVM package will finally build on Debian without any additional tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz accepted this revision. glaubitz added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ glaubitz wrote: > Do we need want to run the test for i386

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ glaubitz wrote: > Do we need want to run the test for

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ Do we need want to run the test for i386 anymore?

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. Thanks, this finally fixes the build for me. I wasn't aware that there was a `getArchNameForCompilerRTLib()` function in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk created this revision. hvdijk added a reviewer: glaubitz. hvdijk added a project: clang. Herald added subscribers: pengfei, dberris. hvdijk requested review of this revision. Herald added a subscriber: cfe-commits. x86_64-linux-gnu and x86_64-linux-gnux32 use different ABIs and objects