[PATCH] D100276: [clang] p1099 3/5: using Enum::member

This revision was automatically updated to reflect the committed changes. Closed by commit rG012898b92cad: [clang] p1099 using enum part 1 (authored by urnathan). Changed prior to commit: https://reviews.llvm.org/D100276?vs=349634&id=350578#toc Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 349634. urnathan added a comment. Rebasing again. Please review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 349044. urnathan added a comment. Rebase and fix conflict CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clan

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 347403. urnathan added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaD

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM. An additional review here would be nice though. > good, it appears the patch bot fail is fixed -- it seems unhappy with > non-tree-like dependency graphs, and tries to apply each reachable

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan added a comment. good, it appears the patch bot fail is fixed -- it seems unhappy with non-tree-like dependency graphs, and tries to apply each reachable patch as many times as it is reachable :( The data race failure seems entirely unconnected with this patch -- please correct me if I

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 345973. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaTemp

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 345959. urnathan edited the summary of this revision. urnathan added a comment. rebased, trying to resolve patch 4's bot fail CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/B

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan marked an inline comment as done. urnathan added inline comments. Comment at: clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp:20 class C { +public: int g(); bruno wrote: > bruno wrote: > > > The change to > > > clang/test/CXX/dcl.dcl/b

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 345487. urnathan added a comment. Address Bruno's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h cla

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan marked 5 inline comments as done. urnathan added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12370 // If we weren't able to compute a valid scope, it might validly be a // dependent class scope or a dependent enumeration unscoped scope. If

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

bruno added a comment. Overall looks good, one more comment below. Comment at: clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp:20 class C { +public: int g(); bruno wrote: > > The change to clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl