[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c9bcf0e3549: [Clang][Coroutine][DebugInfo] Relax test ordering requirement (authored by jmorse). Changed prior to commit:

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

dongAxis1944 accepted this revision. dongAxis1944 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100298/new/ https://reviews.llvm.org/D100298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. One optional nit and LGTM, assuming the DILocalVariable ordering is consistent with what we see downstream. Comment at: clang/test/CodeGenCoroutines/coro-dwarf.cpp:1

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

jmorse updated this revision to Diff 337793. jmorse added a comment. Right you are -- another thing I didn't clock was that this test was running all of the LLVM passes (generating many instances of the coroutine function). Latest revision disables those passes so that there are only

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

dongAxis1944 added a comment. @jmorse I am not familiar with CHECK-DAG. And @probinson 's suggestion might be useful, any ideas? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100298/new/ https://reviews.llvm.org/D100298

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

probinson added a comment. I am not 100% convinced this has the desired effect. I believe what it does is: - Search for the first occurrence of each of "val" "moParam" and "mcParam" - After the last of the above occurrences, ensure there are no other occurrences of "val" "moParam" or "mcParam"

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

jmorse created this revision. jmorse added a reviewer: dongAxis1944. Herald added subscribers: ChuanqiXu, lxfind. jmorse requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, The test added in D97533 (and