This revision was automatically updated to reflect the committed changes.
Closed by commit rG3637c5c8ec3d: [clang] [AArch64] Fix Windows va_arg handling
for larger structs (authored by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mstorsjo added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106
uint64_t Members = 0;
IsIndirect = !isHomogeneousAggregate(Ty, Base, Members);
}
rnk wrote:
> rnk wrote:
> > Do we need to worry about H[VF]As passed to variadic
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106
uint64_t Members = 0;
IsIndirect = !isHomogeneousAggregate(Ty, Base, Members);
}
rnk wrote:
>
rnk added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106
uint64_t Members = 0;
IsIndirect = !isHomogeneousAggregate(Ty, Base, Members);
}
Do we need to worry about H[VF]As passed to variadic functions, or is there a
special case
mstorsjo created this revision.
mstorsjo added reviewers: rnk, efriedma, TomTan, maxim-kuvyrkov.
Herald added subscribers: danielkiss, pengfei, kristof.beyls.
mstorsjo requested review of this revision.
Herald added a project: clang.
Aggregate types over 16 bytes are passed by reference.
