This revision was automatically updated to reflect the committed changes.
Closed by commit rGaf7ab81ce310: [WebAssembly] Use standard intrinsics for
f32x4 and f64x2 ops (authored by tlively).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100411/new/
sunfish added a comment.
Great, thanks! And yes, switching to roundeven for both scalar and SIMD ISel
sounds right to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100411/new/
https://reviews.llvm.org/D100411
_
tlively added a comment.
The Wasm rounding semantics
(https://webassembly.github.io/spec/core/exec/numerics.html#op-fnearest) are
essentially the same as the semantics for roundeven
(https://llvm.org/docs/LangRef.html#llvm-roundeven-intrinsic, added to LLVM in
May 2020), so that would be the l
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
This looks good to me! Could you briefly comment here on what the issue with
`llvm.roundeven` is?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: wingo, ecnelises, sunfish, hiraditya,
jgravelle-google, sbc100.
tlively requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
N
