[PATCH] D100619: [ASTReader] Only mark module out of date if not already compiled

2021-04-16 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1206b95e0703: [ASTReader] Only mark module out of date if not already compiled (authored by bnbarham, committed by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D100619: [ASTReader] Only mark module out of date if not already compiled

2021-04-16 Thread Ben Barham via Phabricator via cfe-commits
bnbarham added inline comments. Comment at: clang/test/Modules/Inputs/error/error.h:1 +#pragma mark mark + akyrtzi wrote: > Is this pragma relevant for the test? I'll double check but I believe assertions are hit regardless, but with assertions off the test does

[PATCH] D100619: [ASTReader] Only mark module out of date if not already compiled

2021-04-16 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi added inline comments. Comment at: clang/test/Modules/Inputs/error/error.h:1 +#pragma mark mark + Is this pragma relevant for the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100619/new/ https://rev

[PATCH] D100619: [ASTReader] Only mark module out of date if not already compiled

2021-04-15 Thread Ben Barham via Phabricator via cfe-commits
bnbarham created this revision. bnbarham added a reviewer: akyrtzi. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a module contains errors (ie. it was built with -fallow-pcm-with-compiler-errors and had errors) and was from th