[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev created this revision. ABataev added reviewers: jdoerfert, abhinavgaba, jyu2, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added subscribers: openmp-commits, sstefan1. Herald added projects: clang, OpenMP. The implicitly generated

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

jdoerfert added a comment. Can we use the reproducer from the bug report, I want an outermost array section with objects that have a declare mapper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100673/new/ https://reviews.llvm.org/D100673 __

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

abhinavgaba added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:7 + +// XFAIL: clang + Thanks for the fixes, Alexey. Are you planning on handling this case separately? Repository: rG LLVM Github

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2695694 , @jdoerfert wrote: > Can we use the reproducer from the bug report, I want an outermost array > section with objects that have a declare mapper. Sure, will add. Comment at: openmp/libompt

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev updated this revision to Diff 338210. ABataev added a comment. Added repro from PR49698 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100673/new/ https://reviews.llvm.org/D100673 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks for the quick fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100673/new/ https://reviews.llvm.org/D100673

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

protze.joachim requested changes to this revision. protze.joachim added a comment. This revision now requires changes to proceed. I tested the patch and still get wrong results (I modified the `declare_mapper_nested_default_mappers_complex_structure.cpp` test to use my verbose printf from bugzil

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2698168 , @protze.joachim wrote: > I tested the patch and still get wrong results (I modified the > `declare_mapper_nested_default_mappers_complex_structure.cpp` test to use my > verbose printf from bugzilla): > >

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev updated this revision to Diff 338624. ABataev added a comment. Fixes and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100673/new/ https://reviews.llvm.org/D100673 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/d

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

protze.joachim accepted this revision. protze.joachim added a comment. This revision is now accepted and ready to land. The latest changes fix the issue. I tested with x86_64 and nvidia offloading. The behavior and tests looks good to me, just one comment. Comment at: openmp/

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_complex_structure.cpp:123-126 + assert(outer[1].arr[1].arr[0].data1 == 11 && + outer[1].arr[1].arr[0].data2 == 22 && + outer[1].arr[1].arr[1].data1

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG079884225a55: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault. (authored by ABataev). Repository: rG LLVM Github Monorepo CH

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

jdoerfert added a comment. I think this broke GridMini (https://github.com/meifeng/GridMini/tree/openmp) :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100673/new/ https://reviews.llvm.org/D100673 ___

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2714087 , @jdoerfert wrote: > I think this broke GridMini (https://github.com/meifeng/GridMini/tree/openmp) > :( Will investigate this on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2714087 , @jdoerfert wrote: > I think this broke GridMini (https://github.com/meifeng/GridMini/tree/openmp) > :( Hmm, this app does not use mappers. Are you sure that this commit is the actual cause of the problem? A

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

jdoerfert added a comment. In D100673#2716916 , @ABataev wrote: > In D100673#2714087 , @jdoerfert > wrote: > >> I think this broke GridMini >> (https://github.com/meifeng/GridMini/tree/openmp) :( > > Hmm, this a

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2716929 , @jdoerfert wrote: > In D100673#2716916 , @ABataev wrote: > >> In D100673#2714087 , @jdoerfert >> wrote: >> >>> I think this

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

cchen added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == &x[0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + Do we really expect `sa[1].f.b` be the same as `&x[0]`? Shou

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == &x[0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + cchen wrote: > Do we really expect `sa[1].f.b` be the same