[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. Recommitted with a fix for the M1 openMP issue: To https://github.com/llvm/llvm-project.git 3aaac01aab2f..6b938d2ead2c main -> main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100807/new

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2720277 , @thakis wrote: > In D100807#2719873 , @arphaman > wrote: > >> We have M1 CI running internally but it's post >> commit only right now

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

thakis added a comment. In D100807#2719873 , @arphaman wrote: > We have M1 CI running internally but it's post > commit only right now Which tests is it running? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2719561 , @thakis wrote: > In D100807#2718006 , @arphaman > wrote: > >> It appears that your bot is running on a Mac with M1 >> is that correct?

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

thakis added a comment. In D100807#2718006 , @arphaman wrote: > It appears that your bot is running on a Mac with M1 > is that correct? Which OS do you have > installed? Thanks Correct, it's an M1

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. Reverted in ab0df6c0346e for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100807/new/ https://reviews.llvm.org/D100807 _

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2717778 , @thakis wrote: > Looks like this breaks tests on mac/arm (by making two unexpectedly pass): > http://45.33.8.238/macm1/8249/step_7.txt > > Please take a look, and please revert for now if it takes a while to

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2717778 , @thakis wrote: > Looks like this breaks tests on mac/arm (by making two unexpectedly pass): > http://45.33.8.238/macm1/8249/step_7.txt > > Please take a look, and please revert for now if it takes a while to

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

thakis added a comment. Looks like this breaks tests on mac/arm (by making two unexpectedly pass): http://45.33.8.238/macm1/8249/step_7.txt Please take a look, and please revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cc62043c8bf: [clang][driver] Use the provided arch name for a Darwin target triple (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. Neat, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100807/new/ https://reviews.llvm.org/D100807 ___ cfe-commits mailing list cfe-commits@

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2702675 , @ab wrote: > This sounds nice! One idea, maybe more dangerous, not sure which is better: > in `setTripleTypeForMachOArchName`, we already have a couple `setArchName` > calls, I think that's why `arm64e` i

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman updated this revision to Diff 339027. arphaman added a comment. Updated with Ahmed's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100807/new/ https://reviews.llvm.org/D100807 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/aarch64-cpus.c clan

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

ab added a comment. This sounds nice! One idea, maybe more dangerous, not sure which is better: in `setTripleTypeForMachOArchName`, we already have a couple `setArchName` calls, I think that's why `arm64e` is left alone in the `aarch64-cpus.c` test. Maybe we can do the `setArchName` call for

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman created this revision. arphaman added reviewers: ab, t.p.northover. Herald added subscribers: ributzka, kristof.beyls. arphaman requested review of this revision. Herald added a project: clang. Clang's driver currently prints out different default triples when it's invoked like this on A