vsavchenko created this revision.
Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp,
donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware,
xazax.hun.
vsavchenko requested review of this revision.
Herald added a project: clang.
Herald added a sub
vsavchenko updated this revision to Diff 338835.
vsavchenko added a comment.
Update comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100839/new/
https://reviews.llvm.org/D100839
Files:
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/
NoQ added a comment.
This is a major improvement. `MallocChecker` will have to catch up on that.
Hopefully through increased code re-use.
Comment at:
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:651
+
+ return Result;
+}
I
vsavchenko added inline comments.
Comment at:
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:651
+
+ return Result;
+}
NoQ wrote:
> I feel semi-irrational urge to add comments whenever NRVO is employed.
I know, and I lacked trus
NoQ added inline comments.
Comment at:
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:967-968
+
+ // While looking for the last var bindings, we can still find
+ // `AllocFirstBinding` to be one of them. In situations like this,
+ // it would
vsavchenko updated this revision to Diff 340544.
vsavchenko added a comment.
Add test for the case when there are no good alternatives
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100839/new/
https://reviews.llvm.org/D100839
Files:
clang/lib/S
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great, thanks!~
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100839/new/
https://reviews.llvm.org/D100839
__
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61ae2db2d7a9: [analyzer] Adjust the reported variable name
in retain count checker (authored by vsavchenko).
Repository:
rG LLVM Github Monorepo
