[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool UseTemporary,

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

dexonsmith added a subscriber: sammccall. dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool UseT

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100872/new/ https://reviews.llvm.org/D100872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool UseTemporary,

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

rnk added a subscriber: dexonsmith. rnk added a comment. +@dexonsmith who touched this API last. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool Remove

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates the functions createDefaultOutputFile, createOutputFile, createOutputFileImpl to use OpenFlags instea