[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

2021-04-26 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5987d7c59da5: [clang-format] fix indent in alignChainedConditionals (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101033/new/ https:

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

2021-04-23 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. I also have a limited understanding based on the original patch https://github.com/llvm/llvm-project/commit/4db94094b469b4715d08ef37f1799bf3ea7ca8ea together with examining affected test cases. I believe the intention of this section is to handle, e.g., the alignment of

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

2021-04-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can't say I really understand this (either the before/after state). It seems like we're trying to vertically-align a bunch of operands to a ?: chain, and this patch stops aligning the on

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

2021-04-22 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang-format was indenting the lines following the `?` in the added test case by +5 instead of +4. This only happens in a very specific situation, wher