This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcea736e5b8a4: [clangd] Hide inlay hints capability behind a
command-line flag (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES S
nridge updated this revision to Diff 342310.
nridge marked 4 inline comments as done.
nridge added a comment.
Address review comments, including making the flag not hidden
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101275/new/
https://reviews.ll
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:312
+ desc("Enable preview of InlayHints feature"), init(false),
+ Hidden};
+
njames93 wrote:
> Does it make sense to hide this flag?
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:312
+ desc("Enable preview of InlayHints feature"), init(false),
+ Hidden};
+
Does it make sense to hide this flag? This is a feature
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1482
Bind.method("textDocument/semanticTokens/full/delta", this,
&ClangdLSPServer::onSemanticTokensDelt
nridge created this revision.
nridge added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Githu
