[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

2021-04-26 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: llvm/cmake/config-ix.cmake:285 +# The st_mtim.tv_nsec member of a `stat` structure is not reliable on some AIX +# environments. + set(HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC 0) jsji wrote: > Maybe add a warning

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

2021-04-26 Thread Hubert Tong via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rGbdc4ec04d42a: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX (authored by h

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

2021-04-26 Thread Jinsong Ji via Phabricator via cfe-commits
jsji accepted this revision as: jsji. jsji added inline comments. Comment at: llvm/cmake/config-ix.cmake:285 +# The st_mtim.tv_nsec member of a `stat` structure is not reliable on some AIX +# environments. + set(HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC 0) Maybe add a wa

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

2021-04-26 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D101323#2717925 , @jsji wrote: > Have we considered workaround this in `llvm/lib/Support/Unix/Path.inc` > instead? Yes. I think this is a more general fix that would automatically apply in other situations whe

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

2021-04-26 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. Have we considered workaround this in `llvm/lib/Support/Unix/Path.inc` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 ___ cfe-co

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

2021-04-26 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision as: daltenty. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 _

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

2021-04-26 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: daltenty, Xiangling_L, jsji. Herald added a subscriber: mgorny. hubert.reinterpretcast requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The value observed