[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval created this revision. clementval added reviewers: jdoerfert, kiranchandramohan. Herald added subscribers: rriddle, guansong, hiraditya, yaxunl. clementval requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, stephenneuendorffer. Herald added

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 341589. clementval added a comment. Fix global variable names. Separator comes from OpenMP runtime information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Fil

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur added a comment. testcase That is, something that calls createOffloadMaptypes/createOffloadMapnames independently of any front-end. Can be as simply as calling it and checking tha

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

jdoerfert added a comment. I assume clang tests apply here. It replaces clang functionality after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 ___ cfe-c

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur added a comment. In D101503#2729385 , @jdoerfert wrote: > I assume clang tests apply here. It replaces clang functionality after all. The policy so far was to have LLVM functionality tested in LLVM itself. See https://reviews.llvm.org/D91470#

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 341938. clementval marked 5 inline comments as done. clementval added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Files: c

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval added a comment. In D101503#2727906 , @Meinersbur wrote: > testcase > > > That is, something that calls createOffloadMaptypes/createOffloa

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 ___

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 342508. clementval added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Front

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 342512. clementval added a comment. Rebase 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Fro

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63f8226f259a: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions (authored by clementval). Repository: rG LLVM Github