[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

This revision was automatically updated to reflect the committed changes. Closed by commit rG61dc0f2b593d: [Format] Dont sort includes if DisableFormat is true (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 ___ cfe-commits mailing list

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

njames93 updated this revision to Diff 342778. njames93 added a comment. Add test case demonstrating new behvaiour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 Files: clang/lib/Format/Format.cpp

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

njames93 added a comment. In D101628#2734501 , @curdeius wrote: > Is it testable? I guess it would be, gimme a few to have a look at format unittests and I'll rustle up a quick test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

curdeius added a comment. Is it testable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Jep, that would also confuse myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I've seen this asked for multiple time, I think this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

njames93 created this revision. njames93 added a reviewer: MyDeveloperDay. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://llvm.org/PR35099. I'm not sure if this decision was intentional but its definitely confusing