[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv created this revision. exv added reviewers: krasimir, MyDeveloperDay. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for the null-coalescing assignment and null-forgiving oeprators. https://docs.microsoft.com/en-

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

MyDeveloperDay added a comment. Thank you for the patch Comment at: clang/lib/Format/TokenAnnotator.cpp:3197 +Right.is(TT_CSharpNullCoalescingAssignment)) + return true; + should this honour SpaceBeforeAssignmentOperators ? Repository: rG LLVM

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342497. exv added a comment. Remove special whitespace handling for ??= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/TokenAnnotator.cpp cla

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3197 +Right.is(TT_CSharpNullCoalescingAssignment)) + return true; + MyDeveloperDay wrote: > should this honour SpaceBeforeAssignmentOperators ? Good point. Looking more closel

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:365 + + verifyFormat("test \?\?= ABC;", Style); + verifyFormat("test \?\?= true;", Style); Why do you escape `?`? I've never seen that. Repository: rG LLVM Git

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342521. exv added a comment. Herald added a subscriber: JDevlieghere. Fixing arc, hopefully? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/For

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342520. exv added a comment. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, Sanitizers, dcaballe, cota, teijeong, frasercrmck, dexonsmith, rdzhabarov, tatianashp, lxfind, dang, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendor

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. Hey all, I'm really sorry for the noise, I screwed up my arc command to revise the submission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:365 + + verifyFormat("test \?\?= ABC;", Style); + verifyFormat("test \?\?= true;", Style); HazardyKnusperkeks wrote: > Why do you escape `?`? I've never seen that. Apparently, ??

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Looks very good already. Just some questions and test requests. Requesting changes so it shows up nicely in the revision queue. Comment at: clang/lib/Format/To

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342594. exv marked 2 inline comments as done. exv added a comment. - [clang-format] Add more support for C# 8 nullables - Fix null-coalescing assignment whitespace behavior - Incorporate feedback from curdeius - Combine JS and CS types/parsing Repository: rG L

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1593 +tok::kw_namespace, tok::r_paren, tok::r_square, tok::r_brace, +tok::kw_false, tok::kw_true, Keywords.kw_type, Keywords.kw_get, +Keywords.kw_set) || ---

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. That's great. Thanks for working on this and for the cleanup. Comment at: clang/lib/Format/FormatTokenLexer.cpp:102 + +// FIXME: Investigate what token type giv

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342813. exv marked an inline comment as done. exv added a comment. - Remove obsolete comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/For

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv marked an inline comment as done. exv added a comment. According to the wiki, it seems like someone who has commit access must now submit this change. Comment at: clang/lib/Format/FormatTokenLexer.cpp:102 + +// FIXME: Investigate what token type gives the correct opera

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. In D101702#2736886 , @exv wrote: > According to the wiki, it seems like someone who has commit access must now > submit this change. Yes, I'll land it. Please provide "Name " for commit attribution if it differs from the info

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv marked an inline comment as done. exv added a comment. Eliza Velasquez Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-com

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. I have completed two other formatting fixes related to C# 8 nullables since my last commit. Should I create a new review request for those or update this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://r

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. Preferably a new one unless it's something really minor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. Could you please rebase to re-run the CI (that failed for sum unrelated reason)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ c

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

krasimir accepted this revision. krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1563 + if (Current.Previous) { +bool isIdentifier = +Style.Language == FormatStyle::LK_JavaScript nit: `s/isIdentifier/IsIden

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

krasimir added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:135 return; +} } nit: use spaces for indentation, no tabs (Phabricator makes it look this line starts with a tab character) Repository: rG LLVM Github Monorepo C

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

jbcoe added a comment. Thanks for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:135 return; +} } krasimir wrote: > nit: use spaces for indentation, no tabs (Phabricator makes it look this line > starts with a tab character) That's not a

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 343142. exv marked 3 inline comments as done. exv added a comment. - Incorporate krasimir's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Fo

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. Rebased and comments addressed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 343177. exv added a comment. Rebase again in an attempt to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/FormatToken.h clang/lib/Form

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

This revision was automatically updated to reflect the committed changes. Closed by commit rGa437befa8f85: [clang-format] Add more support for C# 8 nullables (authored by exv, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1017