[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2766411 , @mikerice wrote: > In D101849#2764825 , @ABataev wrote: > >> No, it is not required. Most probably, needed to simplify test checks, >> nothing else. > >

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a comment. In D101849#2766411 , @mikerice wrote: > In D101849#2764825 , @ABataev wrote: > >> No, it is not required. Most probably, needed to simplify test checks, >> nothing else. > > Thanks.

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

mikerice added a comment. In D101849#2764825 , @ABataev wrote: > No, it is not required. Most probably, needed to simplify test checks, > nothing else. Thanks. I'd like to remove the "REQUIRES: x86-registered-target", the -O1 for CHECK6,10, and

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ABataev added a comment. In D101849#2764798 , @jdoerfert wrote: > In D101849#2764703 , @mikerice > wrote: > >>> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd >>> -emit-llvm %s -o -

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a subscriber: ABataev. jdoerfert added a comment. In D101849#2764703 , @mikerice wrote: >> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd >> -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 > > Is

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

mikerice added a comment. > // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd > -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 Is there a good reason to run this with -O1? Doing so makes it super sensitive to which llvm passes run and now this test fails for

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2741980 , @DavidSpickett wrote: > I've required X86 target for this test to get our bots green again. Thanks David for the workaround. I agree with Johannes's comments below. It looks like a bug. Repository:

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a comment. In D101849#2741980 , @DavidSpickett wrote: > I've required X86 target for this test to get our bots green again. We can have that as a workaround sure. > Either way this seems like a bug given that clang usually doesn't

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

DavidSpickett added a comment. I've required X86 target for this test to get our bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 ___

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

DavidSpickett added a comment. The failing test line is: // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 It passes if you have the X86 backend enabled but fails if you do not. Our bots usually have only Arm

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

DavidSpickett added a comment. @ggeorgakoudis `Clang::parallel_for_codegen.cpp` is failing on some of our bots: https://lab.llvm.org/buildbot/#/builders/43/builds/5751 https://lab.llvm.org/buildbot/#/builders/107/builds/7585 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG207b08a9130b: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis updated this revision to Diff 343210. ggeorgakoudis added a comment. More updates to tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 Files: clang/test/OpenMP/cancel_codegen.cpp

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis updated this revision to Diff 343197. ggeorgakoudis added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 Files: clang/test/OpenMP/cancel_codegen.cpp

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956cae2f09b2: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks for making this happen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis created this revision. Herald added subscribers: jfb, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo