This revision was automatically updated to reflect the committed changes.
Closed by commit rGec725b307f3f: [clang-format] Fix C# nullable-related errors
(authored by exv, committed by curdeius).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
exv updated this revision to Diff 343180.
exv added a comment.
Rebase again in an attempt to fix CI
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101860/new/
https://reviews.llvm.org/D101860
Files:
clang/lib/Format/FormatToken.h
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101860/new/
https://reviews.llvm.org/D101860
___
cfe-commits mailing list
exv updated this revision to Diff 343143.
exv marked an inline comment as done.
exv added a comment.
- Incorporate curdeius's feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101860/new/
https://reviews.llvm.org/D101860
Files:
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM pending CI.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2531
+ parseRecord();
+ // This does not apply for Java, JavaScript and C#.
+ if (Style.Language
curdeius added a comment.
You can add a parent revision so that this patch will be applied upon its
parent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101860/new/
https://reviews.llvm.org/D101860
exv created this revision.
exv requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This diff is based on https://reviews.llvm.org/D101702.
This fixes two errors:
Previously, clang-format was splitting up type identifiers from the
nullable ?.
