This revision was automatically updated to reflect the committed changes.
Closed by commit rG16c7829784f0: [clangd] Check if macro is already in the
IdentifierTable before loading it (authored by qdelacru, committed by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
qdelacru added a comment.
Yes I need help landing this, please use qdela...@cisco.com. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101870/new/
https://reviews.llvm.org/D101870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
please provide an email address (for attribution) if i should land this for you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101870/new/
https://reviews.llvm.org/D101870
__
qdelacru updated this revision to Diff 343141.
qdelacru added a comment.
Added suggested new test case
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101870/new/
https://reviews.llvm.org/D101870
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clangd/unittests/Code
kadircet added a comment.
oh wow thanks! would you mind adding a test case like:
TEST(CompletionTest, NoCrashDueToMacroOrdering) {
EXPECT_THAT(completions(R"cpp(
#define ECHO(X) X
#define ECHO2(X) ECHO(X)
int finish_preamble = E^CHO(2);)cpp")
.Completio
qdelacru created this revision.
qdelacru added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
qdelacru requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Having nested macros
