This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbc5b5ea037db: [clang][patch][FPEnv] Make initialization of
C++ globals strictfp aware (authored by mibintc).
Repository:
rG LLVM Github Monorepo
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Giving my official LGTM now that there's been a week for folks to comment with
additional concerns.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://re
aaron.ballman added a comment.
The changes LGTM, but I'd appreciate additional sign-off from someone with more
expertise in this area. @rjmccall, can you take a look to see if it addresses
your concerns?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
mibintc updated this revision to Diff 360225.
mibintc added a comment.
Removed use of auto, and used different capitalization for local var name
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102343/new/
https://reviews.llvm.org/D102343
Files:
cl
aaron.ballman added inline comments.
Comment at: clang/include/clang/AST/Decl.h:1993
const DeclarationNameInfo &NameInfo, QualType T,
- TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified,
- ConstexprSpecKind ConstexprKind,
+
mibintc marked an inline comment as done.
mibintc added a comment.
Question for Aaron
Comment at: clang/include/clang/AST/Decl.h:1993
const DeclarationNameInfo &NameInfo, QualType T,
- TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified,
mibintc updated this revision to Diff 360222.
mibintc added a comment.
Partially respond to @aaron.ballman 's review by refactoring a change into a
separate commit, but I'll push back on another request, I'll add that reply
inline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
aaron.ballman added inline comments.
Comment at: clang/include/clang/AST/Decl.h:1993
const DeclarationNameInfo &NameInfo, QualType T,
- TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified,
- ConstexprSpecKind ConstexprKind,
+
mibintc marked an inline comment as done.
mibintc added inline comments.
Comment at: clang/lib/Sema/SemaLambda.cpp:395
MethodNameLoc),
- MethodType, MethodTypeInfo, SC_None,
+ MethodType, MethodTypeInfo, SC_None, /*UsesFPIntrin*/ false,
mibintc updated this revision to Diff 359772.
mibintc added a reviewer: zahiraam.
mibintc added a comment.
Respond to @aaron.ballman 's review, rebased & used clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102343/new/
https://reviews.ll
aaron.ballman added reviewers: rsmith, erichkeane.
aaron.ballman added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:2685
+ bool UsesFPIntrin, bool isInline,
+ bool isImplicitlyDeclared,
mibintc added inline comments.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:700
CurCodeDecl = D;
- if (const auto *FD = dyn_cast_or_null(D))
-if (FD->usesSEHTry())
- CurSEHParent = FD;
+ const FunctionDecl *FD = dyn_cast_or_null(D);
+ if (FD && FD->usesSEHTry(
mibintc created this revision.
mibintc added reviewers: kpn, rjmccall, aaron.ballman, pcc.
Herald added a subscriber: martong.
Herald added a reviewer: shafik.
mibintc requested review of this revision.
Herald added a project: clang.
In the proposed patch https://reviews.llvm.org/D81178 @kpn point
13 matches
Mail list logo