This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe6f88dc01a72: [clang][Fuchsia] Turn on relative-vtables by
default for Fuchsia (authored by leonardchan).
Repository:
rG LLVM Github Monorepo
CHA
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102374/new/
https://reviews.llvm.org/D102374
___
leonardchan updated this revision to Diff 345484.
leonardchan marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102374/new/
https://reviews.llvm.org/D102374
Files:
clang/include/clang/Basic/TargetCXXABI.h
clang/incl
phosek added inline comments.
Comment at: clang/include/clang/Basic/TargetCXXABI.h:69
+ // default.
+ static bool supportsRelativeCXXVTables(const llvm::Triple &T) {
+return T.isOSFuchsia();
I think that `supports` here is a bit misleading, I'd expect the r
leonardchan added a comment.
Ready for reviews. Let me know if I should add other reviewers for the
flag/option processing. This shouldn't impact how the experimental flag is
used. It's just processing it that's different.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
leonardchan updated this revision to Diff 345293.
leonardchan added a comment.
Change the tablegen definition of
`-f[no-]experimental-relative-c++-abi-vtables` from a BoolFOption to two
separate flags so we can control the default value of the
`RelativeCXXABIVTables` LangOption more explicitly
leonardchan added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3293
+static bool SupportsRelativeCXXVTables(const llvm::Triple &T) {
+ return T.isOSFuchsia();
+}
phosek wrote:
> Could we instead enable it inside `FuchsiaCXXABI`?
So we c
phosek added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3293
+static bool SupportsRelativeCXXVTables(const llvm::Triple &T) {
+ return T.isOSFuchsia();
+}
Could we instead enable it inside `FuchsiaCXXABI`?
Repository:
rG LLVM Gith
leonardchan created this revision.
leonardchan added a project: clang.
Herald added subscribers: dang, phosek.
leonardchan requested review of this revision.
All fuchsia targets will now use the relative-vtables ABI by default.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D102
