[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-09-03 Thread Alexandre Rames via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG655bea4226b4: [modules] Use `HashBuilder` and `MD5` for the module hash. (authored by arames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ htt

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-09-03 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 _

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-31 Thread Alexandre Rames via Phabricator via cfe-commits
arames updated this revision to Diff 369794. arames marked an inline comment as done. arames added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/includ

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-31 Thread Alexandre Rames via Phabricator via cfe-commits
arames marked 2 inline comments as done. arames added inline comments. Comment at: clang/include/clang/Basic/ObjCRuntime.h:486 + template + friend void addHash(llvm::HashBuilderImpl &HBuilder, + const ObjCRuntime &OCR) { dexonsmith wrote:

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-31 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. A couple of suggestions inline, but this basically LGTM. @jansvoboda11 @Bigcheese : can you take a look as well and confirm this looks reasonable from your perspectives? Comment at: clang/include/clang/Basic/ObjCRuntime.h:486 + template + friend

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-30 Thread Alexandre Rames via Phabricator via cfe-commits
arames added inline comments. Comment at: clang/include/clang/Basic/ObjCRuntime.h:486 + template + friend void addHash(llvm::HashBuilderImpl &HBuilder, + const ObjCRuntime &OCR) { I have added these in the same line as existing `hash_value

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-30 Thread Alexandre Rames via Phabricator via cfe-commits
arames updated this revision to Diff 369489. arames added a comment. Fix to native endianness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/include/clang/Basic/ObjCRuntime.h clang/incl

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-29 Thread Alexandre Rames via Phabricator via cfe-commits
arames added inline comments. Comment at: clang/include/clang/Serialization/ModuleFileExtension.h:89 + using ExtensionHashBuilder = + llvm::HashBuilderImpl; + virtual void hashExtension(ExtensionHashBuilder &HBuilder) const; This obviously needs to be fixe

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-27 Thread Alexandre Rames via Phabricator via cfe-commits
arames marked 3 inline comments as done. arames added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4580 - return llvm::APInt(64, code).toString(36, /*Signed=*/false); + return llvm::APInt(64, Hash.getValue()).toString(36, /*Signed=*/false); } --

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

2021-08-27 Thread Alexandre Rames via Phabricator via cfe-commits
arames added a comment. I still need to go through earlier comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 ___ cfe-commits mailing list cfe-commits@li