[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

abhinavgaba added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &) _

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

olestrohm added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &) __g

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

abhinavgaba added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &) _

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG438cf5577e72: [OpenCL] Fix missing addrspace on implicit move assignment operator (authored by olestrohm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1032

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103252/new/ https://reviews.llvm.org/D103252 ___ cfe-commits mailing list cfe-commits@

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

olestrohm updated this revision to Diff 348969. olestrohm added a comment. Cleaned up the test by renaming the struct and making the test compile. The test has also been moved to `clang/test/AST` as suggested, since it really just makes sure that the generated AST contains the correct implicit me

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

svenvh added a comment. > I also added a new test file to check the output AST. If there's a better > place for this test I will move it there. If you're primarily interested in the AST, then it doesn't have to be a Sema test I guess. In that case `clang/test/AST` seems to be a better place, a

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This fixes the missing address space on `this` in the impl