[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-06-01 Thread Christopher Rhodes via Phabricator via cfe-commits
crr0004 added a comment. Whoops. Hit close without adding this comment. Okay thank you for that @sammccall and @kadirect. Ultimately shared this patch was I found it useful but wasn't sure if it would fit with the project. Is there somewhere I can read about project direction/decisions? Like

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-06-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This is definitely an interface that makes sense for the purpose you describe (profiling index performance) but I'm less convinced it makes sense for clangd's *primary* use cases. For example, our default policy gives different answers for code in different paths,

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-05-31 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. > Strictly speaking you could, assuming you have a compile database and it's > okay to have copies or symlinks of the database. Well you wouldn't have index shards without a compilation database anyway though. > That does speak to another issue though; moving the

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-05-31 Thread Christopher Rhodes via Phabricator via cfe-commits
crr0004 added a comment. Strictly speaking you could, assuming you have a compile database and it's okay to have copies or symlinks of the database. I would have probably done that if I had realised I could. That does speak to another issue though; moving the compile database to move the

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-05-31 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. > I mainly added this because I am doing profiling of indexing and needed a way > for multiple instances of index files not to conflict with each other. If this is solely for testing purposes, can't you make use of `--compile-commands-dir` instead? You'll also need to

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-05-30 Thread Christopher Rhodes via Phabricator via cfe-commits
crr0004 created this revision. crr0004 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. crr0004 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This adds a new option