jyknight added inline comments.
Comment at: clang/lib/CodeGen/Address.h:26
llvm::Value *Pointer;
+ llvm::Type *PointeeType;
CharUnits Alignment;
erichkeane wrote:
> I think this will still end up being a problem when we try to look into the
> type for
erichkeane added inline comments.
Comment at: clang/lib/CodeGen/Address.h:26
llvm::Value *Pointer;
+ llvm::Type *PointeeType;
CharUnits Alignment;
I think this will still end up being a problem when we try to look into the
type for multi-dimension
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/Address.h:31
+ : Address(pointer, nullptr, alignment) {}
+ Address(llvm::Value *pointer, llvm::Type *PointeeType, CharUnits alignment)
+ : Pointer(pointer), PointeeType(PointeeType),
nikic added a comment.
Maybe send a mail to cfe-dev to solicit some help with the opaque pointer
migration on the clang side?
Comment at: clang/lib/CodeGen/Address.h:29-30
public:
Address(llvm::Value *pointer, CharUnits alignment)
- : Pointer(pointer),
dblaikie added a comment.
The changes look like the right direction to me - though I don't know/couldn't
confirm whether more changes will be needed in other places.
Comment at: clang/lib/CodeGen/Address.h:29-30
public:
Address(llvm::Value *pointer, CharUnits alignment)
-
aeubanks created this revision.
aeubanks added reviewers: dblaikie, rsmith.
aeubanks published this revision for review.
aeubanks added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is definitely WIP, but I'd like to make sure that this is the right
