[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 354422. stefanp added a comment. Updated the name of the option to cover all of the inconsistencies for vector pixel/bool. Future patches will continue to use this option to define the behaviour of these two types. Reworded the warning message. Added InGroup<

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

nemanjai added a comment. I haven't had time to review this yet, but I just wanted to chime in on the option spelling and description. I think we should go with: -faltivec-src-compat={xl|gcc|mixed} Source-level compatibility for Altivec vectors (for PowerPC targets). This includes resu

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

bmahjour added a comment. Sorry I didn't mention this in my earlier comment about the option name, but I think that all inconsistencies in handling vector bool/pixel types should be controlled by a single compatibility option. For example the current special handling of initialization (splat vs

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 353126. stefanp added a comment. Moved if statement out of switch and added the Default=Mixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files: clang/include/

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

bmahjour added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:248 + enum class VectorCompareCompatKind { +// Default clang behaviour. +// All vector compares produce scalars except vector Pixel and vector bool. How about adding `Def

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 351467. stefanp added a comment. Updated the name of the option to vector-compare compat. Added clang test lines to the test cases. Added deprecation warnings to the current default behaviour of vector bool and vector pixel. Repository: rG LLVM Github Mono

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp added a comment. In D103615#2799498 , @bmahjour wrote: > As far as I can see, there is no good reason for the special treatment of > vector bool/pixel going forward. Could we drop this special treatment, or at > least change the default to use s

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

bmahjour added a comment. As far as I can see, there is no good reason for the special treatment of vector bool/pixel going forward. Could we drop this special treatment, or at least change the default to use a scalar results across the board (consistent with XL's behaviour and clang's current

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp created this revision. stefanp added reviewers: nemanjai, lei, rsmith. Herald added subscribers: dexonsmith, dang. stefanp requested review of this revision. Herald added a project: clang. Added the option -vector-abi-compat=[default,gcc,xl]. The default behavior for clang is for all vecto