[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

krasimir added a comment. In D103615#2858433 , @bmahjour wrote: > In D103615#2852430 , @krasimir > wrote: > >> I'm unfamiliar with the altivec API. What's a reasonable source code update >> that preserves the cu

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. In D103615#2852430 , @krasimir wrote: > I'm unfamiliar with the altivec API. What's a reasonable source code update > that preserves the current default behavior `-altivec-src-compat=mixed` under > `-altivec-src-compat=xl`, i.e

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

krasimir added a comment. I'm unfamiliar with the altivec API. What's a reasonable source code update that preserves the current default behavior `-altivec-src-compat=mixed` under `-altivec-src-compat=xl`, i.e., under `-altivec-src-compat=xl` how would we compare vector bool or vector pixel to

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90dfd059198e: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp updated this revision to Diff 355320. stefanp added a comment. Removed the lines that specified that checks were auto generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files: clang/incl

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp updated this revision to Diff 355315. stefanp added a comment. Updated test cases to avoid failures on non assert builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files: clang/include/cla

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847965 , @stefanp wrote: > In D103615#2847650 , @dblaikie > wrote: > >> In D103615#2847118 , @bmahjour >> wrote: >> >>> In D103615#

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp added a comment. In D103615#2847650 , @dblaikie wrote: > In D103615#2847118 , @bmahjour > wrote: > >> In D103615#2847047 , @stefanp >> wrote: >> >>> I'm sorry I

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847704 , @bmahjour wrote: >> (generally: disabling the test in non-asserts builds isn't the right path, >> modifying the test so it doesn't depend on asserts IR naming is the right >> path) > > Agreed. > >> Yes, pro

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. > (generally: disabling the test in non-asserts builds isn't the right path, > modifying the test so it doesn't depend on asserts IR naming is the right > path) Agreed. > Yes, probably removing the entry: check would be sufficient - give it a test > locally and see h

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847118 , @bmahjour wrote: > In D103615#2847047 , @stefanp wrote: > >> I'm sorry I missed the asserts requirement. >> I will recommit this patch after I add `REQUIRES: asserts`

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. In D103615#2846245 , @dblaikie wrote: > As mentioned in the reverting commit - these tests fail in non-asserts > builds, because they assume named IR instructions (like the named entry BB > label), which aren't provided on a no

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. In D103615#2847047 , @stefanp wrote: > I'm sorry I missed the asserts requirement. > I will recommit this patch after I add `REQUIRES: asserts`. Instead of disabling the tests for non-assert builds, can we just remove the `entr

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp reopened this revision. stefanp added a comment. This revision is now accepted and ready to land. I'm sorry I missed the asserts requirement. I will recommit this patch after I add `REQUIRES: asserts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2846251 , @dyung wrote: > In D103615#2846245 , @dblaikie > wrote: > >> As mentioned in the reverting commit - these tests fail in non-asserts >> builds, because they assume n

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dyung added a comment. In D103615#2846245 , @dblaikie wrote: > As mentioned in the reverting commit - these tests fail in non-asserts > builds, because they assume named IR instructions (like the named entry BB > label), which aren't provided on a non-a

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. As mentioned in the reverting commit - these tests fail in non-asserts builds, because they assume named IR instructions (like the named entry BB label), which aren't provided on a non-asserts build (there's a flag to turn them on - but that's probably not the right fi

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3fe847f9d90: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour accepted this revision. bmahjour added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 ___