[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

2021-06-12 Thread Markus Böck via Phabricator via cfe-commits
zero9178 created this revision. zero9178 added reviewers: davrec, bruno, rsmith, aaron.ballman. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses a performance issue I noticed when using clang-12 to compile proj

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

2021-06-12 Thread David Rector via Phabricator via cfe-commits
davrec added a comment. Was this performance hit when using the static analyzer? A quick search suggests `isAnyDestructorNoReturn()` is only called within the analyzer, whereas comparable CXXRecordDecl methods whose results are stored (`hasIrrelevantDestructor()` etc.) seem to be called somewh

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

2021-06-12 Thread Markus Böck via Phabricator via cfe-commits
zero9178 added a comment. In D104182#2815397 , @davrec wrote: > Was this performance hit when using the static analyzer? A quick search > suggests `isAnyDestructorNoReturn()` is only called within the analyzer, > whereas comparable CXXRecordDecl method

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

2021-06-13 Thread Markus Böck via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff3a89a7b94: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of… (authored by zero9178). Repository: rG LLVM Github Monorepo