[PATCH] D104424: [Sema] Fix for PR50741

2021-06-17 Thread Abhinav Gaba via Phabricator via cfe-commits
abhinavgaba added a comment. Thanks for fixing this, @chrish_ericsson_atx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits mailing list

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-17 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx added a comment. Delivered as rGfc6ec9b98cf9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-17 Thread Chris Hamilton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc6ec9b98cf9: [Sema] Fix for PR50741 (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-17 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx marked 2 inline comments as done. chrish_ericsson_atx added a comment. Thanks for the hints, @erichkeane ! Especially thanks for pointing out the root cause early on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-17 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. Yep, that works, still approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-17 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx updated this revision to Diff 352711. chrish_ericsson_atx edited the summary of this revision. chrish_ericsson_atx added a comment. Addressed review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Two small changes to the test that you can do as a part of committing. Thanks! Comment at: clang/test/Sema/unbounded-array-bounds.c:17

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-16 Thread Abhinav Gaba via Phabricator via cfe-commits
abhinavgaba added a comment. @erichkeane, can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits mailing list

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-16 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx updated this revision to Diff 352569. chrish_ericsson_atx added a comment. Updated summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D104424: [Sema] Fix for PR50741

2021-06-16 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx created this revision. chrish_ericsson_atx added reviewers: erichkeane, aaron.ballman, abhinavgaba. chrish_ericsson_atx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed crash when doing pointer math on a void