[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats added a comment. In D104494#2827708 , @gbalats wrote: > In D104494#2827639 , @vitalybuka > wrote: > >> https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this >> patch > > Looking in

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats added a comment. In D104494#2827639 , @vitalybuka wrote: > https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this > patch Looking into this. I missed (due to the "\\" in the expression) updating this: https://github.com/ll

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104494/new/ https://reviews.llvm.org/D104494

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats marked an inline comment as done. gbalats added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1134 + Asm.replace(Pos, 1, Suffix + "@"); +} GV->getParent()->setModuleInlineAsm(Asm); stephan.yichao.zhao

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

stephan.yichao.zhao added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1134 + Asm.replace(Pos, 1, Suffix + "@"); +} GV->getParent()->setModuleInlineAsm(Asm); Based on http://web.mit.edu/rhel-doc/3/rhel-as-en

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

kcc added a comment. Yey, great idea! :) (I am not reviewing the code; but the change looks straightforward) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104494/new/ https://reviews.llvm.org/D104494 __