[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. In D104714#2872826 , @tstellar wrote: > It looks like this patch breaks the > utils/update_cc_test_checks/check-globals.test on stand-alone builds of > clang, because it hard codes lit to lit.py in the llvm source tree. I thin

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. It looks like this patch breaks the utils/update_cc_test_checks/check-globals.test on stand-alone builds of clang, because it hard codes lit to lit.py in the llvm source tree. I think it should using the lit passed to -DLLVM_EXTERNAL_LIT= (if that option was specified

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841457 , @thakis wrote: > Another thing: https://reviews.llvm.org/harbormaster/unit/view/789318/ > > # command stderr: > > /var/lib/buildkite-agent/builds/llvm-project/clang/test/utils/update_cc_test_checks/check-g

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. Another thing: https://reviews.llvm.org/harbormaster/unit/view/789318/ # command stderr: /var/lib/buildkite-agent/builds/llvm-project/clang/test/utils/update_cc_test_checks/check-globals.test:83:10: error: LIT-RUN: expected string not found in input LIT-RUN: PASS:

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841304 , @thakis wrote: > I landed a fix attempt for my thing in > fda790fbfa0cba426d5e3787429a51e09ec64c6d > . Thanks! Repository: rG LLVM Gi

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. I landed a fix attempt for my thing in fda790fbfa0cba426d5e3787429a51e09ec64c6d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://revie

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841229 , @thakis wrote: > Oh I see this assumes that lit.site.cfg.py is below clang_obj_root. I guess > that's my problem, looking… Let me know if the patch isn't general enough, or if I can help in some other way.

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. Oh I see this assumes that lit.site.cfg.py is below clang_obj_root. I guess that's my problem, looking… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/49790/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mai

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9eaf0d120d32: [UpdateCCTestChecks] Support --check-globals (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2835874 , @ggeorgakoudis wrote: > LGTM too! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mai

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny updated this revision to Diff 353998. jdenny marked an inline comment as done. jdenny added a comment. Applied arichardson's suggestion: comment on exclusion of separator comments. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D10471

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

ggeorgakoudis added a comment. LGMT too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2834696 , @arichardson wrote: > Thanks for working on this! Thanks for the review. > We have some tests downstream that check globals and currently have to use > `// UTC_ARGS: --disable` to manually retain them. Doe

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

arichardson accepted this revision. arichardson added a comment. Thanks for working on this! We have some tests downstream that check globals and currently have to use `// UTC_ARGS: --disable` to manually retain them. The other update script tests compare to an expected output file instead of u

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2833238 , @jdoerfert wrote: > LG, cool :) Thanks for the reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cf

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny updated this revision to Diff 353765. jdenny added a comment. Fixed the reported test failure. (Sorry, I had accidentally put that fix in a later patch even though the associated test is in this patch.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.l

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, cool :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 __

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny created this revision. jdenny added reviewers: arichardson, ggeorgakoudis, jdoerfert, MaskRay, mtrofin, greened. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. This option is already supported by update_test_checks.py, but