[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

stuart added a comment. > Unfortunately I cannot look at this in detail right now, but I'll reply > quickly for a heads up: The problem was not how to detect kernels, but the > ABI/CC mismatch to the > clSetKerneArg() with (user facing) arguments that get split to multiple args > or vice versa.

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2859742 , @pekka.jaaskelainen wrote: >> Ok, thanks for clarification. Does it mean there is something we need to add >> to LLVM somewhere to make it work correctly? Would it be specific to Arm or >> generally for a

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

pekka.jaaskelainen added a comment. > Ok, thanks for clarification. Does it mean there is something we need to add > to LLVM somewhere to make it work correctly? Would it be specific to Arm or > generally for all CPU targets? To my understanding, what is required is to keep SPIR_KERNEL CC wor

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2857958 , @pekka.jaaskelainen wrote: >> The reason why we would like to fix it is that upstream clang has a crash >> currently when OpenCL sources are compiled for any Arm CPU: >> https://bugs.llvm.org/show_bug.cgi

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

pekka.jaaskelainen added a comment. > The reason why we would like to fix it is that upstream clang has a crash > currently when OpenCL sources are compiled for any Arm CPU: > https://bugs.llvm.org/show_bug.cgi?id=50841. Do you have any other > suggestions to avoid this problem? > > FYI clang a

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2849268 , @pekka.jaaskelainen wrote: > Does this break clSetKernelArg() for ARM CPUs in PoCL? I believe so far it > has worked for ARM - just wondering why you decide to drop it now? > > https://github.com/pocl/pocl

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

pekka.jaaskelainen added a comment. Does this break clSetKernelArg() for ARM CPUs in PoCL? I believe so far it has worked for ARM - just wondering why you decide to drop it now? https://github.com/pocl/pocl/issues/1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104858/new/ https://rev

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia updated this revision to Diff 355166. Anastasia retitled this revision from "[OpenCL][ARM] Fix ICE when compiling a source with the kernel" to "[OpenCL][ARM] Fix ICE when compiling a kernel". Anastasia edited the summary of this revision. Anastasia added reviewers: pekka, svenvh. Anastas