MaskRay added a comment.
Herald added a subscriber: wangpc.
We need some tests.
https://maskray.me/blog/2021-08-08-toolchain-testing#i-dont-know-whether-a-test-is-needed
Adding some to `clang/test/Preprocessor/init-aarch64.c` should cover many
changes, but we also need one to cover
Amanieu added a comment.
The situation around -mabi for AArch64 is a bit awkward: Clang uses it to
select the ARM64 calling convention (`-mabi=aapcs` vs `-mabi=darwinpcs`) while
GCC uses it to select between LP64 and ILP32. I'm not sure how we should be
handling this.
Repository:
rG LLVM
nickdesaulniers added a comment.
Herald added a project: All.
The linux kernel uses a build time invocation of the compiler for feature
detection of the `-mabi=lp64` command line flag, which clang-16 currently
doesn't support.
Looking at https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html,
Amanieu added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104931/new/
https://reviews.llvm.org/D104931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Amanieu added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104931/new/
https://reviews.llvm.org/D104931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Amanieu created this revision.
Amanieu added reviewers: t.p.northover, aemerson, kristof.beyls.
Herald added a subscriber: danielkiss.
Amanieu requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is a follow-up to D94143
