This revision was automatically updated to reflect the committed changes.
Closed by commit rG4e5d9c88033f: [Internalize] Preserve variables externally
initialized. (authored by hliao).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105135/new/
https:
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105135/new/
https://reviews.llvm.org/D105135
__
hliao updated this revision to Diff 357053.
hliao added a comment.
Revert part of tests back and convert them into positive ones.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105135/new/
https://reviews.llvm.org/D105135
Files:
clang/test/CodeGe
yaxunl added a comment.
LGTM. Pls change the negative tests to positive tests as Artem suggested.
Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:20
-// DEV-NEG-NOT: @v1
-__device__ int v1;
tra wrote:
> hliao wrote:
> > BTW, as clang codegen tests,
hliao updated this revision to Diff 356721.
hliao added a comment.
Kindly PING for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105135/new/
https://reviews.llvm.org/D105135
Files:
clang/test/CodeGenCUDA/host-used-device-var.cu
clang/t
tra added inline comments.
Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:21-24
-__device__ int v1;
-
-// DEV-NEG-NOT: @v2
-__constant__ int v2;
These should be changed to positive checks to verify that they are emitted.
Ditto for other tests.
=
hliao updated this revision to Diff 355764.
hliao added a comment.
Fix typo. Kindly PING for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105135/new/
https://reviews.llvm.org/D105135
Files:
clang/test/CodeGenCUDA/host-used-device-var.cu
hliao added inline comments.
Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:20
-// DEV-NEG-NOT: @v1
-__device__ int v1;
BTW, as clang codegen tests, those checks should not rely on middle-end
optimizations to work correctly.
Comm
hliao created this revision.
hliao added reviewers: yaxunl, bogner.
Herald added subscribers: ormris, hiraditya.
hliao requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
- ``externally_initialized`` variables would be initial
