[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added a comment. In D105320#2905887 , @rnk wrote: > Yes, I filed https://bugs.llvm.org/show_bug.cgi?id=51221 for it. I plan to > disable the test under asan for now. :-( Thanks for taking care of it though! Repository: rG LLVM Github

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

rnk added a comment. Yes, I filed https://bugs.llvm.org/show_bug.cgi?id=51221 for it. I plan to disable the test under asan for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added a comment. I received this report from one of the bots: https://lab.llvm.org/buildbot/#/builders/5/builds/9633/steps/13/logs/stdio ` FAIL: Clang :: CodeGenCXX/debug-info-enum-i128.cpp (5356 of 77963) TEST 'Clang :: CodeGenCXX/debug-info-enum-i128.cpp'

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf84c70a37939: [CodeView] Saturate values bigger than supported by APInt. (authored by mizvekov). Changed prior to commit:

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3167 + + // TODO: Need to support bigger ints like __int128. + OS.AddComment("Value"); rnk wrote: > I don't think we need a TODO here. If Microsoft ever adds an encoding

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with minor comment adjustments Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3167 + + // TODO: Need to support bigger ints like __int128. +

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361547. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: llvm/include/llvm/ADT/APInt.h llvm/include/llvm/IR/DIBuilder.h

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361543. mizvekov marked 4 inline comments as done. mizvekov added a comment. - Expose and use APInt::isSingleWord. - Use ApInt::getLimitedValue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361527. mizvekov marked an inline comment as done. mizvekov added a comment. - rebase on top of D106585 - Reimplement test based on IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

rnk added subscribers: dblaikie, MaskRay, LemonBoy. rnk added a comment. I decided it would be faster and more convenient to respond in the form of a code review for clang, so here it is: D106585 Assuming that goes through, go ahead and rebase onto that after

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 360648. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 360645. mizvekov added a comment. - Really `git add` the test case this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: