This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGacf0a6428681: [sanitizer] Fix __sanitizer_kernel_sigset_t
endianness issue (authored by iii).
Changed prior to commit:
https://reviews.llvm.org/D1
uweigand added a comment.
The SystemZ specific changes all look good to me now, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105629/new/
https://reviews.llvm.org/D105629
___
cfe-commits mailing
iii updated this revision to Diff 358431.
iii added a comment.
- Fix style issues (seems like arc diff is linting only the top commit?).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105629/new/
https://reviews.llvm.org/D105629
Files:
clang/lib/
iii updated this revision to Diff 358363.
iii added a comment.
Based on Ulrich's feedback I tested the series on RHEL7, which, in
addition to an old kernel, contains an old glibc and an old toolchain.
This uncovered a few extra issues, which are fixed here:
- Call __tls_get_offset() in order to f
uweigand added inline comments.
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123
+#if defined(__s390x__)
+ ProtectRange(HiAppMemEnd(), 0xf000ull);
+#endif
iii wrote:
> uweigand wrote:
> > iii wrote:
> > > uweigand wrote:
> > > > Did y
iii added inline comments.
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123
+#if defined(__s390x__)
+ ProtectRange(HiAppMemEnd(), 0xf000ull);
+#endif
uweigand wrote:
> iii wrote:
> > uweigand wrote:
> > > Did you test this on older ke
uweigand added inline comments.
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123
+#if defined(__s390x__)
+ ProtectRange(HiAppMemEnd(), 0xf000ull);
+#endif
iii wrote:
> uweigand wrote:
> > Did you test this on older kernels without 5-l
iii added inline comments.
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123
+#if defined(__s390x__)
+ ProtectRange(HiAppMemEnd(), 0xf000ull);
+#endif
uweigand wrote:
> Did you test this on older kernels without 5-level page table supp
uweigand added a comment.
See inline comments ... otherwise the SystemZ platform-specific parts look good
to me.
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123
+#if defined(__s390x__)
+ ProtectRange(HiAppMemEnd(), 0xf000ull);
+#endif
iii marked an inline comment as done.
iii added a comment.
Regarding the openmp test failures: I tried check-openmp on a x86_64 machine,
and they occur both with and without this patch series, so must be unrelated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
iii marked an inline comment as done.
iii added inline comments.
Comment at: compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:781
+ // TSAN. Act as if we ran out of memory.
+ internal_munmap(res, sz);
+ errno = errno_ENOMEM;
dvyukov wrote:
> TS
iii updated this revision to Diff 357889.
iii added a comment.
- Fix a local variable naming issue CheckAndProtect().
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105629/new/
https://reviews.llvm.org/D105629
Files:
clang/lib/Driver/ToolChains/L
iii updated this revision to Diff 357471.
iii added a comment.
- Reserve the address space "tail" in the "[TSan] Define C/C++ address ranges
for SystemZ" patch.
- Drop the "[TSan] Simulate OOM in mmap_interceptor()" patch.
- Group "[TSan] Use zeroext for function parameters" with the common code
dvyukov added a comment.
Some solid work here.
I only have a question re mmap handling.
Comment at: compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:781
+ // TSAN. Act as if we ran out of memory.
+ internal_munmap(res, sz);
+ errno = errno_ENOMEM;
--
iii created this revision.
iii added reviewers: kcc, dvyukov, uweigand.
Herald added subscribers: jfb, hiraditya, mgorny.
iii requested review of this revision.
Herald added projects: clang, Sanitizers, LLVM.
Herald added subscribers: llvm-commits, Sanitizers, cfe-commits.
This patch series implem
15 matches
Mail list logo
