[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5f47eedeb02: [OpenCL] NULL redefined as nullptr in C++ mode. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 ___ cfe-commits mailing list

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:26 #ifdef CL20 // Accept explicitly pointer to generic address space in OpenCL v2.0. Anastasia wrote: > while we are at it, do you min

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna updated this revision to Diff 359702. Topotuna added a comment. Separate NFC performed in D106254 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 Files: clang/lib/Headers/opencl-c-base.h clang/te

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:26 #ifdef CL20 // Accept explicitly pointer to generic address space in OpenCL v2.0. while we are at it, do you mind changing this check into `__OPENCL_CPP_VERSION__ == 200`

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:13 +#if defined(__OPENCL_CPP_VERSION__) +// expected-error@+2{{cannot initialize a variable of type '__global int *__private' with an rvalue of type '__gl

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna updated this revision to Diff 359256. Topotuna added a comment. Patch made compatible with changes to D105988 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 Files: clang/lib/Headers/opencl-c-base.

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:2 +// RUN: %clang_cc1 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=CL1.0 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Redefines NULL as nullptr instead of ((void*)0) in C++ for OpenCL. Such internal representation o