[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 363534. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:5638 ImplicitConversionSequence ICS = - CCE == Sema::CCEK_ExplicitBool - ? TryContextuallyConvertToBool(S, From) - : TryCopyInitialization(S, From, T, -

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 360840. cor3ntin added a comment. It turns out that explicit was doing the right thing (as outlined in P1401 ), but noexcept was not. I've reworked the handling of noexcept so that noexcept and explicit specifier use the same

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:5638 ImplicitConversionSequence ICS = - CCE == Sema::CCEK_ExplicitBool - ? TryContextuallyConvertToBool(S, From) - : TryCopyInitialization(S, From, T, -

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 359677. cor3ntin added a comment. Fix cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/cxx2a-

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 359558. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/cxx2a-explicit

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Completes the support for P1401R5 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106216 Files: clang/lib/Sema/SemaOverload.cpp