[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

2021-07-22 Thread Amy Huang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e2ad26b08a2: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

2021-07-22 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a subscriber: jmorse. akhuang added a comment. In D106582#2897815 , @dblaikie wrote: > In D106582#2897678 , @akhuang wrote: > >> In D106582#2897599 , @dblaik

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

2021-07-22 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D106582#2897678 , @akhuang wrote: > In D106582#2897599 , @dblaikie > wrote: > >> Looks alright to me. (bit awkward having a documented cc1 option - since the >> cc1 options aren't me

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

2021-07-22 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. In D106582#2897599 , @dblaikie wrote: > Looks alright to me. (bit awkward having a documented cc1 option - since the > cc1 options aren't meant to be user facing - hadn't really thought > about/noticed that when reviewing the do

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

2021-07-22 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright to me. (bit awkward having a documented cc1 option - since the cc1 options aren't meant to be user facing - hadn't really thought about/noticed that when reviewing the docume

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

2021-07-22 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 360926. akhuang added a comment. Herald added a subscriber: dang. add actual flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106582/new/ https://reviews.llvm.org/D106582 Files: clang/docs/UsersManual.rst

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

2021-07-22 Thread Amy Huang via Phabricator via cfe-commits
akhuang created this revision. akhuang added reviewers: dblaikie, probinson. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an opt out flag for constructor homing. Repository: rG LLVM Github Monorepo https://reviews.llvm.o