[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-20 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D106713#3009542 , @tstellar wrote: > @aaronpuchert Can you file a bug? Done: https://bugs.llvm.org/show_bug.cgi?id=51913. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1067

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-20 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. @aaronpuchert Can you file a bug? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-20 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a subscriber: tstellar. aaronpuchert added a comment. In D106713#3009130 , @aaron.ballman wrote: > In D106713#3007878 , @aaronpuchert > wrote: > >> @aaron.ballman, since this is reintroducing

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D106713#3007878 , @aaronpuchert wrote: > @aaron.ballman, since this is reintroducing some warnings after the > relaxation in D102026 , should we bring > this to Clang 13? I think that

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. @aaron.ballman, since this is reintroducing some warnings after the relaxation in D102026 , should we bring this to Clang 13? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b889f826ff5: Thread safety analysis: Warn when demoting locks on back edges (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Accepting the review -- if you don't hear back from @delesley in the next few days, I think it's fine to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-08-30 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-08-04 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Ping @delesley. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-07-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This seems reasonable to me, but I leave it to @delesley for the final sign-off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713