[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

sberg added a comment. In D106924#2919406 , @sberg wrote: > Bisecting shows that this commit causes > > $ echo foo | clang -E -P - > > foo > > to emit a leading newline now. > > That breaks e.g. LibreOffice's `configure`, which uses `echo > __clan

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

sberg added a comment. Bisecting shows that this commit causes $ echo foo | clang -E -P - foo to emit a leading newline now. That breaks e.g. LibreOffice's `configure`, which uses `echo __clang_version__ | clang -E -P -` to obtain the value of that macro, and expects a single line of o

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur added a comment. In D106924#2911145 , @mstorsjo wrote: > @Meinersbur After landing this, can you coordinate with @tstellar to get an > ack for backporting this to the 13.x release branch, which also suffers from > the regression? Release blo

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6b0b16c0f55: [Preprocessor] -E -P: Ensure newline after 8 skipped lines. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur updated this revision to Diff 362612. Meinersbur added a comment. - Use correct base commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924 Files: clang/lib/Frontend/PrintPreprocessedOutput.c

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur updated this revision to Diff 362611. Meinersbur added a comment. - Fix embrassing mistakes in skip-empty-lines test (misspelled "LINEMARKES", MINWS<->MINCOL, absolute path) - Skip-empty-lines now also checks leading whitespace behavior - Fix typos in comments Repository: rG LLVM G

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

mstorsjo added a subscriber: tstellar. mstorsjo added a comment. @Meinersbur After landing this, can you coordinate with @tstellar to get an ack for backporting this to the 13.x release branch, which also suffers from the regression? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

mstorsjo added a comment. Thanks! I can confirm that this fixes the issue I ran into. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924 ___ cfe-commits mailing li

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur created this revision. Meinersbur added reviewers: aaron.ballman, mstorsjo, dblaikie. Meinersbur added a project: clang. Meinersbur requested review of this revision. The implementation of -fminimize-whitespace (D104601 ) revised the logic when to emit