[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

This revision was automatically updated to reflect the committed changes. Closed by commit rG8930af45c35b: [PowerPC] Implement XL compatibility builtin __addex (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://revi

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 366094. lei added a comment. Fix name of new warning message to be more accuratly represent the diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

stefanp accepted this revision. stefanp added a comment. Thank you for adding the `DiagGroup`. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 ___ cfe-com

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 366062. lei added a comment. Update diag id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/include/clang/Basic

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 365816. lei added a comment. Add -W flag to new warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang/include/clang/Basic/BuiltinsPPC.def clang

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

NeHuang added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 __

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr9-warning.c:4 +// RUN: -verify %s + +extern unsigned long long ull; NeHuang wrote: > can we also add the run lines for 64 bit LE Linux, 64 bit AIX and 32 bit AIX? > Will also n

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 365480. lei marked 2 inline comments as done. lei added a comment. update sema check condition and remove duplicate tc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Fil

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

NeHuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3426 + case PPC::BI__builtin_ppc_addex: { +if (SemaFeatureCheck(*this, TheCall, "power9-vector", + diag::err_ppc_builtin_only_on_arch, "9") || I think we start

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/P9InstrResources.td:1434 + ADDEX, + ADDEX8 )> { let Unsupported = 1; } nemanjai wrote: > You have added the 64-bit version of this, but it seems this is only > available for 64-bit operands in 64-

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Requesting changes until my comment is answered/addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://revie

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/P9InstrResources.td:1434 + ADDEX, + ADDEX8 )> { let Unsupported = 1; } You have added the 64-bit version of this, but it seems this is only available for 64-bit operands in 64-bit mode. Under

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 362734. lei added a comment. put back unintentional space change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang/include/clang/Basic/BuiltinsPPC.def clan

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 362536. lei added a comment. remove extra space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/include/clang/B

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 362535. lei added a comment. fix minor wording and spelling mistakes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei created this revision. lei added reviewers: stefanp, nemanjai, NeHuang, power-llvm-team. Herald added subscribers: shchenz, hiraditya. lei requested review of this revision. Herald added projects: clang, LLVM. Add builtin and intrinsic for `__addex`. This patch is part of a series of patches