This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc3c1826c310c: Set TargetCPUName for AIX to default to pwr7.
(authored by jamieschmeiser).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
jamieschmeiser updated this revision to Diff 362760.
jamieschmeiser added a comment.
Respond to review comment: expand testing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107063/new/
https://reviews.llvm.org/D107063
Files:
clang/lib/Driver/ToolChains/CommonArgs.cpp
clang/test/D
ZarkoCA added a comment.
Thanks @jamieschmeiser this change LGTM but I'll defer to
@hubert.reinterpretcast for final approval.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107063/new/
https://reviews.llvm.org/D107063
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM with comment.
Comment at: clang/test/Driver/aix-mcpu-default.c:9
-// Check that the target cpu defaults to power4 on AIX7.1 and below.
jamieschmeiser created this revision.
jamieschmeiser added reviewers: hubert.reinterpretcast, ZarkoCA, stevewan.
jamieschmeiser requested review of this revision.
Herald added a project: clang.
Set the TargetCPUName for AIX to default to pwr7, removing the setting
of it based on the major/minor of
